Merged
Conversation
Member
julien-nc
commented
Apr 9, 2025
julien-nc
commented
- Use psalm 6.4.0 (higher is too restrictive on Php versions and it's hard to run psalm locally)
- Add a matrix in the psalm action
- Update composer dependencies
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
enh/noid/use-psalm-6
branch
from
e5f83d6 to
63a0bc3
Compare
marcelklehr
reviewed
Apr 9, 2025
Member
|
Did you have no issues with the Override attribute missing and code being unreachable? |
julien-nc
force-pushed
the
enh/noid/use-psalm-6
branch
from
051d311 to
4f4415b
Compare
Member
Author
|
@marcelklehr No, maybe thanks to |
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
enh/noid/use-psalm-6
branch
from
4f4415b to
55ea8a4
Compare
marcelklehr
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.